Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug: GPUs are not released in Reusable Training Service #3941

Merged
merged 1 commit into from
Jul 16, 2021
Merged

Fix bug: GPUs are not released in Reusable Training Service #3941

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions ts/nni_manager/training_service/reusable/trialDispatcher.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,9 @@ class TrialDispatcher implements TrainingService {
* @param trial
*/
private releaseEnvironment(trial: TrialDetail): void {
if (true === this.enableGpuScheduler) {
this.gpuScheduler.removeGpuReservation(trial);
}
if (trial.environment !== undefined) {
if (trial.environment.runningTrialCount <= 0) {
throw new Error(`TrialDispatcher: environment ${trial.environment.id} has no counted running trial!`);
Expand All @@ -740,9 +743,6 @@ class TrialDispatcher implements TrainingService {
trial.environment.latestTrialReleasedTime = Date.now();
trial.environment = undefined;
}
if (true === this.enableGpuScheduler) {
this.gpuScheduler.removeGpuReservation(trial);
}
}

private async handleMetricData(trialId: string, data: any): Promise<void> {
Expand Down