[Model Compression] Expand export_model arguments: dummy input and onnx opset_version #3968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready for review @J-shang @QuanluZhang |
J-shang
reviewed
Jul 21, 2021
| device = torch.device('cpu') | ||
| input_data = torch.Tensor(*input_shape).to(device) | ||
| else: | ||
| input_data = dummy_input |
There was a problem hiding this comment.
what if user both set dummy_input and device
There was a problem hiding this comment.
I think device should be ignored in that case. Have updated the docstring.
There was a problem hiding this comment.
recommand we also input_data = dummy_input.to(device), or this may confuse user, if user also set device but we ignore it.
There was a problem hiding this comment.
But I think this operation may fail when e.g., dummy_input is a tuple
J-shang
approved these changes
Jul 21, 2021
ultmaster
approved these changes
Jul 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3964.