Add condition control when passing parameters bounds to scipy.minimize. #4977
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please review this pull request. @liuzhe-lz @ultmaster @J-shang @suiguoxin @leckie-chn @QuanluZhang |
|
This PR fails pylint test, but the problem is caused by #4883. It seems it will be fixed later. |
suiguoxin
approved these changes
Jul 13, 2022
ultmaster
approved these changes
Jul 15, 2022
liuzhe-lz
approved these changes
Jul 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
See Issue. When using GP tuner, it will pass wrong search space bound to scipy, which will fail bound check. Previous code is:
But GP tuner should support both quniform and qloguniform, which is [low, high, q].
bound['_value'][-1]will visit q instead of higher bound.