Fix build on FreeBSD 12 #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change fixes build on FreeBSD 12.
freebsd-git
pushed a commit
to freebsd/freebsd-ports
that referenced
this pull request
Nov 24, 2021
While here, temporarily mark as BROKEN on FreeBSD 12. One of the
native node modules does not compile with the following error:
In file included from ../src/keyboard_x.cc:6:
../src/keymapping.h:40:3: error: unknown type name 'pthread_t'; did you mean 'pthread'?
pthread_t tid;
^~~~~~~~~
pthread
/usr/include/stdio.h:157:9: note: 'pthread' declared here
struct pthread *_fl_owner; /* current owner */
^
In file included from ../src/keyboard_x.cc:6:
../src/keymapping.h:40:13: error: field has incomplete type 'pthread'
pthread_t tid;
^
/usr/include/stdio.h:157:9: note: forward declaration of 'pthread'
struct pthread *_fl_owner; /* current owner */
^
2 errors generated.
A fix to the node module has been proposed at:
microsoft/node-native-keymap#31
Changelog:
- https://code.visualstudio.com/updates/v1_59
- https://code.visualstudio.com/updates/v1_60
- https://code.visualstudio.com/updates/v1_61
- https://code.visualstudio.com/updates/v1_62
ocochard
pushed a commit
to ocochard/freebsd-ports
that referenced
this pull request
Nov 25, 2021
While here, temporarily mark as BROKEN on FreeBSD 12. One of the
native node modules does not compile with the following error:
In file included from ../src/keyboard_x.cc:6:
../src/keymapping.h:40:3: error: unknown type name 'pthread_t'; did you mean 'pthread'?
pthread_t tid;
^~~~~~~~~
pthread
/usr/include/stdio.h:157:9: note: 'pthread' declared here
struct pthread *_fl_owner; /* current owner */
^
In file included from ../src/keyboard_x.cc:6:
../src/keymapping.h:40:13: error: field has incomplete type 'pthread'
pthread_t tid;
^
/usr/include/stdio.h:157:9: note: forward declaration of 'pthread'
struct pthread *_fl_owner; /* current owner */
^
2 errors generated.
A fix to the node module has been proposed at:
microsoft/node-native-keymap#31
Changelog:
- https://code.visualstudio.com/updates/v1_59
- https://code.visualstudio.com/updates/v1_60
- https://code.visualstudio.com/updates/v1_61
- https://code.visualstudio.com/updates/v1_62
|
Thank you! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include
pthread.hforpthread_tto avoid the following build error on FreeBSD 12: