Protect resize against NaN and Infinity

Fixes #316
microsoft · Oct 22, 2019 · 3a896a5 · 3a896a5
1 parent 74edc71
commit 3a896a5
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/unixTerminal.ts b/src/unixTerminal.ts
@@ -257,6 +257,9 @@ export class UnixTerminal extends Terminal {
    */
 
   public resize(cols: number, rows: number): void {
+    if (cols <= 0 || rows <= 0 || isNaN(cols) || isNaN(rows) || cols === Infinity || rows === Infinity) {
+      throw new Error('resizing must be done using positive cols and rows');
+    }
     pty.resize(this._fd, cols, rows);
     this._cols = cols;
     this._rows = rows;

diff --git a/src/windowsTerminal.ts b/src/windowsTerminal.ts
@@ -142,7 +142,7 @@ export class WindowsTerminal extends Terminal {
    */
 
   public resize(cols: number, rows: number): void {
-    if (cols <= 0 || rows <= 0) {
+    if (cols <= 0 || rows <= 0 || isNaN(cols) || isNaN(rows) || cols === Infinity || rows === Infinity) {
       throw new Error('resizing must be done using positive cols and rows');
     }
     this._defer(() => {