Add type check for cwd

Part of #55
microsoft · Mar 24, 2017 · 4ad2860 · 4ad2860
1 parent 16a36a8
commit 4ad2860
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/src/terminal.ts b/src/terminal.ts
@@ -6,7 +6,7 @@
 import * as path from 'path';
 import { Socket } from 'net';
 import { EventEmitter } from 'events';
-import { ITerminal } from './interfaces';
+import { ITerminal, IPtyForkOptions } from './interfaces';
 
 export abstract class Terminal implements ITerminal {
   protected static readonly DEFAULT_COLS: number = 80;
@@ -27,7 +27,12 @@ export abstract class Terminal implements ITerminal {
 
   protected _internalee: EventEmitter;
 
-  constructor() {
+  constructor(opt?: IPtyForkOptions) {
+    // TODO: Fill in more type checks
+    if (opt.cwd && typeof opt.cwd !== 'string') {
+      throw new Error('cwd must be a string');
+    }
+
     // for 'close'
     this._internalee = new EventEmitter();
   }

diff --git a/src/unixTerminal.ts b/src/unixTerminal.ts
@@ -33,7 +33,7 @@ export class UnixTerminal extends Terminal {
   private slave: any;
 
   constructor(file?: string, args?: ArgvOrCommandLine, opt?: IPtyForkOptions) {
-    super();
+    super(opt);
 
     if (typeof args === 'string') {
       throw new Error('args as a string is not supported on unix.');