Merge pull request #587 from microsoft/robo/cleanup_posix_spawn

refactor: posix_spawn usage for macOS

binding.gyp

@@ -69,21 +69,6 @@
       ]
     }, { # OS!="win"
       'targets': [
-        {
-          'target_name': 'spawn-helper',
-          'type': 'executable',
-          'cflags': ['-Wall'],
-          'sources': [
-            'src/unix/spawn-helper.cc',
-          ],
-          'conditions': [
-            ['OS=="mac"', {
-              "xcode_settings": {
-                "MACOSX_DEPLOYMENT_TARGET":"10.7"
-              }
-            }]
-          ]
-        },
         {
           'target_name': 'pty',
           'include_dirs' : [

scripts/post-install.js

@@ -9,7 +9,6 @@ var BUILD_FILES = [
   path.join(RELEASE_DIR, 'conpty_console_list.pdb'),
   path.join(RELEASE_DIR, 'pty.node'),
   path.join(RELEASE_DIR, 'pty.pdb'),
-  path.join(RELEASE_DIR, 'spawn-helper'),
   path.join(RELEASE_DIR, 'winpty-agent.exe'),
   path.join(RELEASE_DIR, 'winpty-agent.pdb'),
   path.join(RELEASE_DIR, 'winpty.dll'),

src/interfaces.ts

@@ -109,7 +109,6 @@ interface IBasePtyForkOptions {
 export interface IPtyForkOptions extends IBasePtyForkOptions {
   uid?: number;
   gid?: number;
-  closeFDs?: boolean;
 }
 
 export interface IWindowsPtyForkOptions extends IBasePtyForkOptions {

src/native.d.ts

@@ -18,7 +18,7 @@ interface IWinptyNative {
 }
 
 interface IUnixNative {
-  fork(file: string, args: string[], parsedEnv: string[], cwd: string, cols: number, rows: number, uid: number, gid: number, closeFDs: boolean, useUtf8: boolean, onExitCallback: (code: number, signal: number) => void, helperPath: string): IUnixProcess;
+  fork(file: string, args: string[], parsedEnv: string[], cwd: string, cols: number, rows: number, uid: number, gid: number, useUtf8: boolean, onExitCallback: (code: number, signal: number) => void): IUnixProcess;
   open(cols: number, rows: number): IUnixOpenProcess;
   process(fd: number, pty: string): string;
   resize(fd: number, cols: number, rows: number): void;