Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binary build in Travis #64

Closed
Tyriar opened this issue Mar 26, 2017 · 1 comment
Closed

Fix binary build in Travis #64

Tyriar opened this issue Mar 26, 2017 · 1 comment
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
0.6.4

Comments

@Tyriar
Copy link
Member

Tyriar commented Mar 26, 2017

https://travis-ci.org/Tyriar/node-pty/jobs/215118189#L141
@Tyriar Tyriar added this to the 0.7.0 milestone Mar 26, 2017
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Mar 26, 2017
@jerch
Copy link
Collaborator

jerch commented Mar 26, 2017 •
edited
Loading 

...
#error This version of node/NAN/v8 requires a C++11 compiler
...

Seems to be the same problem I had with travis in the termios PR - travis and the outdated C++ compilers.
Also OSX seems still to use the BSD pty system, where the slave devices are named as /dev/tty[p-sP-S][a-z0-9] (See https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man4/pty.4.html)

Tyriar added a commit that referenced this issue Mar 30, 2017
@Tyriar
Abort the build when main npm install script fails
c92a5ea 
Part of #64
@Tyriar Tyriar mentioned this issue Mar 30, 2017
Merged
@Tyriar Tyriar modified the milestones: 0.7.0, 0.6.4 Apr 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
0.6.4
Development

No branches or pull requests
2 participants
@Tyriar @jerch