dependencies updated #183
Merged
dependencies updated #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tyriar
requested changes
Apr 7, 2018
package.json
Outdated
| "cross-env": "^3.2.4", | ||
| "mocha": "^3.1.2", | ||
| "@types/mocha": "^5.0.0", | ||
| "@types/node": "^9.6.2", |
There was a problem hiding this comment.
Updating node types will make it easy to accidentally break old node support without knowing.
There was a problem hiding this comment.
should I leave node LTS instead of latest ? Is just @types/node, right ? IMO, node 6 is too outdated but perhaps you want me to leave it as it was ? please advice and I will make the change, thanks! :) - BTW great project!!
There was a problem hiding this comment.
#179 relies on node 6 as the minimum, I'd say keep @types/node as they were until we want to drop support for node 6.
There was a problem hiding this comment.
there you have it : "@types/node": "^6.0.104" hope it's fine, good job with this library!!! :)
Tyriar
approved these changes
Apr 9, 2018
|
Thanks @cancerberoSgx! |
This was referenced Mar 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.