Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed src from files: decrease published version size #200

Closed
wants to merge 1 commit into from
Closed

Removed src from files: decrease published version size #200

wants to merge 1 commit into from

Conversation

coderaiser
Copy link
Contributor

Added .npmignore

@coderaiser coderaiser changed the title Add npm ignore: decrease published version size Removed src from files: decrease published version size Jun 12, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2018

The src/ files are there on purpose so the source map files resolve correctly. If size is this much of a problem in your application it's probably safe to do a clean up step before you bundle by deleting node_modules/node-pty/**/*.ts and node_modules/node-pty/**/*.js.map

@Tyriar Tyriar closed this Jun 12, 2018
@coderaiser coderaiser deleted the patch-1 branch June 13, 2018 08:07
@coderaiser
Copy link
Contributor Author

So you just want only these files was ignored in #198?

./node_modules/node-pty/src/windowsPtyAgent.test.ts
./node_modules/node-pty/src/terminal.test.ts
./node_modules/node-pty/src/windowsTerminal.test.ts
./node_modules/node-pty/src/unixTerminal.test.ts

@Tyriar
Copy link
Member

Tyriar commented Jun 13, 2018

@coderaiser yep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants