Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix sigint problem #217

Closed
wants to merge 1 commit into from
Closed

fix sigint problem #217

wants to merge 1 commit into from

Conversation

fpronto
Copy link

@fpronto fpronto commented Aug 27, 2018

this fix issue #190

Tyriar
Tyriar reviewed Aug 27, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this was added in 56fc4a4 to work around another bug. Do you know if this will regress in that area? /cc @jerch

@jerch
Copy link
Collaborator

jerch commented Aug 27, 2018

I fear it is not that easy. There are circumstances, where the child process will immediately be aborted after fork if there are custom handlers registered to streams, files etc. in the parent process. Imho a better way is to stop all signal delivery in parent with sigprocmask, fork and reenable the signals afterwards.

@jerch
Copy link
Collaborator

jerch commented Aug 27, 2018

@fpronto: Could you try #218 and see if the problem remains?

@fpronto fpronto closed this Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fpronto @jerch @Tyriar