Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better handle escaping quotes #222

Merged
merged 3 commits into from
Sep 5, 2018
Merged

Better handle escaping quotes #222

merged 3 commits into from
Sep 5, 2018

Conversation

alexr00
Copy link
Member

@alexr00 alexr00 commented Sep 5, 2018

There was a bug with escaping quotes in string array arguments. Part of microsoft/vscode#57452

@alexr00 alexr00 requested a review from Tyriar September 5, 2018 21:05
@alexr00 alexr00 closed this Sep 5, 2018
@alexr00 alexr00 reopened this Sep 5, 2018
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good after the test timeout is fixed 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants