Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node-pty): option to stop handling SIGINT #240

Closed

Conversation

aslushnikov
Copy link

Fixes #190.

@msftclas
Copy link

msftclas commented Oct 30, 2018

CLA assistant check
All CLA requirements met.

@aslushnikov
Copy link
Author

Hi guys,

In many node.js projects that deal with SIGINT/SIGTERM handling, there's an option to disable process signal hooks. This way it's up to the embedder to handle signals and to properly run shutdown logic.

This PR adds the handleSIGINT option to the pty.fork. AFAICT it'll fix the #190 bug - let me know what you think.

Thanks,
Andrey

@jerch
Copy link
Collaborator

jerch commented Oct 31, 2018

@aslushnikov Care to test if #218 solves your issues with this?

@Tyriar
Copy link
Member

Tyriar commented Apr 7, 2020

This should be fixed with #218 which was just merged. Thanks for the PR though.

@Tyriar Tyriar closed this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

process.on('exit') is disabled after spawn a child process.
4 participants