Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add accessors pty and ptsName #516

Merged
merged 1 commit into from
Dec 14, 2021
Merged

Add accessors pty and ptsName #516

merged 1 commit into from
Dec 14, 2021

Conversation

corwin-of-amber
Copy link
Contributor

This is a PR to address #143, in accordance with the discussion in the issue thread.

I threw in a test for the close event which started out as a test for fd until I realized that closing fd (with fs.close) does nothing, for some reason.

@corwin-of-amber
[feature] Add accessors pty and ptsName.
97f2f27 
Closes microsoft#143.
In accordance with the discussion in the issue thread.
@ghost
Copy link

ghost commented Dec 14, 2021 •
edited by ghost
Loading

CLA assistant check
All CLA requirements met.

@Tyriar Tyriar added this to the 1.0.0 milestone Dec 14, 2021
Tyriar
Tyriar approved these changes Dec 14, 2021
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great. CI is currently not running for PRs so hopefully it'll pass when merged 🙂

@Tyriar Tyriar merged commit ed75c34 into microsoft:main Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@corwin-of-amber @Tyriar