Add basic tests for encoding option with PtyFork. #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @KiNgMaR, I'll check this out when I get past all the release stuff at work 😃 |
- raise mocha timeout because sometimes launching a shell is slow. - use separate files for UTF-8 test data to avoid issues with host shell configuration.
|
Thanks for the follow up @KiNgMaR, should ensure no regressions 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Tyriar,
here are the promised test cases for the encoding option. I only added tests for the pty fork part.
I also started adding them for the pty open part, but now I'm not sure whether having the encoding option there even makes sense. Can you maybe elaborate on how a terminal created with pty open would be used from another process? I can only think of redirection to
/dev/pts/123or similar? Is that commonly used?Thanks...!