Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interactive Window busted in Node.js v0.10.x and below #1080

Closed
mousetraps opened this issue Jun 21, 2016 · 3 comments
Closed

Interactive Window busted in Node.js v0.10.x and below #1080

mousetraps opened this issue Jun 21, 2016 · 3 comments
Assignees
@avitalb

Comments

@mousetraps
Copy link
Contributor

Expected
Enter statements into interactive window and they get executed properly

Actual
TypeError: needs a 'context' argument.

image
@mousetraps
Copy link
Contributor Author

@avitalb is looking into this

@mousetraps mousetraps changed the title Interactive Window busted in NTVS 1.2 Beta Interactive Window busted in Node.js v0.10.x and below Jun 21, 2016
@mousetraps
Copy link
Contributor Author

Looks like it's only broken in v0.10.x and below, probably as a result of using new APIs in #876

@mjbvz
Copy link
Contributor

mjbvz commented Jun 21, 2016

See this old Node documentation for vm: https://nodejs.org/docs/v0.10.40/api/vm.html

I suspect we need to change the context creation line to context = vm.createInContext(context)

avitalb pushed a commit to avitalb/nodejstools that referenced this issue Jun 21, 2016
fixed Issue microsoft#1080 - fixed interactive window type error due …
36fb7aa 
…to context not

being returned in node 0.10.x
@avitalb avitalb mentioned this issue Jun 21, 2016
Merged
mjbvz added a commit that referenced this issue Jun 21, 2016
@mjbvz
Merge pull request #1082 from avitalb/i1080
82ac443 
fixed Issue #1080 - fixed interactive window type error due to contex…
@mjbvz mjbvz closed this as completed Jun 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@avitalb avitalb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mousetraps @avitalb @mjbvz