-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TypeScript: Go to definition fails to work in Visual Studio 2015 #18
Comments
Thanks, I'll close the duplicate Codeplex issue. We're focusing on VS2015 for our next milestone, so this issue will definitely make the cut :-) |
According to the linked thread, this only occurs when you are working with two projects, and there is a dot in the filepath. The problem isn't exactly in the open document code, but rather that the VS item id is not set properly in this scenario unless the document is opened first. Is this the only time F12 is not working? |
@mousetraps, yes, the F12 fails when there's a dot in the file path, but works correctly otherwise. The F12 only fails to work in NTVS projects. We also have plain TypeScript project, and they don't have this problem. |
Working together with TS team to resolve this sometime after BUILD. The issue occurs in the OpenDocument code, but it is the arguments passed in that are problematic, not the code itself. One possibility is that TS is making some assumptions about the Project System that do not apply to NTVS, which results in OpenItem being passed an invalid projectHierarchy and vsitemid. |
@mousetraps, is this included in the May release? |
It is not - still investigating, and we pushed it back to the July milestone because it appeared to be a very isolated scenario that would take a lot of time to root cause the first time I played around with it. I may have found a simpler repro now, though, so we'll see... |
@mousetraps, thanks for looking into it. |
Just verified that this is fixed in the latest version of TypeScript 1.5 and NodeTools 1.1 RC, both of which should be released around VS 2015 RTM. |
This looks to be fixed. Thanks! |
@daskul Did you reply to the right issue? Can you clarify? |
@daskul that issue doesn't seem related to the node tools. It seems to be limited to C#/VB and reference assemblies. |
Oops sorry! Im so stupid! :) I'll just delete my comments |
How do i remove typescript from visual studio 2015 as it is driving me crazy with this cannot navigate to caret issue. I do not use typescript and just want it off so I can continue working productively. |
@Taztoons unfortunately you cannot remove TypeScript, however if you don't use TypeScript is shouldn't interfere with your work. What is this 'navigate to caret' issue you mention? Can you open a new bug to explain your issue? |
This issue was logged on the TypeScript project: microsoft/TypeScript#1210.
But turns out to be an NTVS issue. See microsoft/TypeScript#1210 (comment)
The text was updated successfully, but these errors were encountered: