Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript: Go to definition fails to work in Visual Studio 2015 #18

Closed
NoelAbrahams opened this issue Apr 2, 2015 · 14 comments
Closed
Assignees
Milestone

Comments

@NoelAbrahams
Copy link

This issue was logged on the TypeScript project: microsoft/TypeScript#1210.

But turns out to be an NTVS issue. See microsoft/TypeScript#1210 (comment)

@mousetraps
Copy link
Contributor

Thanks, I'll close the duplicate Codeplex issue. We're focusing on VS2015 for our next milestone, so this issue will definitely make the cut :-)

@ASayre ASayre added the bug label Apr 9, 2015
@ASayre ASayre added this to the April milestone Apr 9, 2015
@mousetraps mousetraps self-assigned this Apr 21, 2015
@mousetraps
Copy link
Contributor

According to the linked thread, this only occurs when you are working with two projects, and there is a dot in the filepath.

The problem isn't exactly in the open document code, but rather that the VS item id is not set properly in this scenario unless the document is opened first.

Is this the only time F12 is not working?

@NoelAbrahams
Copy link
Author

@mousetraps, yes, the F12 fails when there's a dot in the file path, but works correctly otherwise.

The F12 only fails to work in NTVS projects. We also have plain TypeScript project, and they don't have this problem.

@mousetraps
Copy link
Contributor

Working together with TS team to resolve this sometime after BUILD. The issue occurs in the OpenDocument code, but it is the arguments passed in that are problematic, not the code itself. One possibility is that TS is making some assumptions about the Project System that do not apply to NTVS, which results in OpenItem being passed an invalid projectHierarchy and vsitemid.

@mousetraps mousetraps modified the milestones: May, April Apr 27, 2015
@mousetraps mousetraps modified the milestone: May May 28, 2015
@NoelAbrahams
Copy link
Author

@mousetraps, is this included in the May release?

@mousetraps
Copy link
Contributor

It is not - still investigating, and we pushed it back to the July milestone because it appeared to be a very isolated scenario that would take a lot of time to root cause the first time I played around with it. I may have found a simpler repro now, though, so we'll see...

@NoelAbrahams
Copy link
Author

@mousetraps, thanks for looking into it.

@mousetraps mousetraps removed their assignment Jun 10, 2015
@paulvanbrenk paulvanbrenk self-assigned this Jul 8, 2015
@paulvanbrenk
Copy link
Contributor

Just verified that this is fixed in the latest version of TypeScript 1.5 and NodeTools 1.1 RC, both of which should be released around VS 2015 RTM.

@NoelAbrahams
Copy link
Author

This looks to be fixed. Thanks!

@paulvanbrenk
Copy link
Contributor

@daskul Did you reply to the right issue? Can you clarify?

@paulvanbrenk
Copy link
Contributor

@daskul that issue doesn't seem related to the node tools. It seems to be limited to C#/VB and reference assemblies.

@jaimesangcap
Copy link

Oops sorry! Im so stupid! :) I'll just delete my comments

@Taztoons
Copy link

How do i remove typescript from visual studio 2015 as it is driving me crazy with this cannot navigate to caret issue. I do not use typescript and just want it off so I can continue working productively.

@paulvanbrenk
Copy link
Contributor

@Taztoons unfortunately you cannot remove TypeScript, however if you don't use TypeScript is shouldn't interfere with your work. What is this 'navigate to caret' issue you mention? Can you open a new bug to explain your issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

7 participants