Add better logging when node is not installed #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bug Poor initial experiance when launching NTVS without node installed. Fix Adds a few more logging points: * Log if npm cannot be found * Log if typings tool install fails * Log if typings tool cannot be found. All these are logged to the output window. Closes microsoft#1069
|
At some point, I'd like to revisit #729. Adding strings is a pain right now and it's far too easy to introduce fun bugs through string name mismatches. |
|
👍 this is a good start, but I'm not entirely sure if this is really a place users will look so we should continue to refine the design. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
Poor initial experiance when launching NTVS without node installed.
Fix
Adds a few more logging points:
All these are logged to the output window.
Testing
Manually tested by messing up node path and then correcting node path to make sure the errors are not shown
Closes #1069