Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1078 Don't block install if VS version is below required version #1099

Merged
merged 1 commit into from
Jun 24, 2016
Merged

#1078 Don't block install if VS version is below required version #1099

merged 1 commit into from
Jun 24, 2016

Conversation

mousetraps
Copy link
Contributor

@mousetraps mousetraps commented Jun 24, 2016 •
edited

Issue #1078
Instead warn users, but allow them to continue with the installation even
if the detected version is less than what NTVS requires
image

Testing
  • Set VS_IS_2015_PRE_UPDATE_2 property to 0 and 1, walk through several installer workflows (install, upgrade, different options)
  • verify dialog pops up when it's set to 1
  • verify doesn't pop up when it's set to 0
  • verify "continue anyways" does not abort install
  • verify "don't install" aborts install
  • verify message box default selections
  • verify dialog pops up at most once in any workflow
  • verify message box text displays appropriately on different windows font sizes

close #1078

@mousetraps
microsoft#1078 Don't block install if VS version is below required ve…
8c9c975 
…rsion

Instead warn users, but allow them to continue with the installation even
if the detected version is less than what NTVS requires
@mousetraps mousetraps mentioned this pull request Jun 24, 2016
Closed
@mousetraps
Copy link
Contributor Author

After this goes in, we'll also want #994 to go in for RC

@mjbvz mjbvz merged commit 8480378 into microsoft:master Jun 24, 2016
@mjbvz mjbvz removed the in-progress label Jun 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't Block Install if VS Version is Below Required Version
3 participants
@mousetraps @msftclas @mjbvz