This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
add cooloff period for rapidly exiting libFuzzer targets #1002
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e handles to be reaped
chkeita
reviewed
Jun 18, 2021
chkeita
approved these changes
Jun 18, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For rapidly exiting libFuzzer targets, the agent can get into a state where it never has a chance for the handles to get reaped. This eventually causes an OOM error in the system.
This enforces that within a given worker, at least 5 seconds have occurred between each execution of the target.
Note, we effectively had a sleep before, but the performance improvements in #941 removed the effective sleep.