This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Update onefuzz supervisor service restart behavior #1055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Increase the dealy between service restart from 100ms to 1s - Prevent the service from restarting more than 10 time in a 20s interval
|
I'm on board with increasing the restart delay is good. We can probably increase the delay even more. On Windows, the delay is 30s. For the bursting, will it stop restarting eventually? If so, I think we probably don't want that. If the reason the app is failing is due to Azure, restarting forever will enable eventual recovery. |
ranweiler
reviewed
Jul 9, 2021
increase restart delay to 30s
ranweiler
approved these changes
Jul 9, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partial fix for #1028