This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
enable configurable virtual network ranges #1268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ke-subnet-configurable
ranweiler
reviewed
Sep 24, 2021
Co-authored-by: Joe Ranweiler <joe@lemma.co>
…z into make-subnet-configurable
ranweiler
approved these changes
Sep 27, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to enable express route changes, we need to allow administrators to configure the virtual network IP ranges used.
1f creates virtual networks with the name of the region. To maintain compatibility with existing deployments as well as enabling continued support to not break existing deployments, this
Without configuration, this change will continue to use
regionas the network name as long as the network config is the defaults. Otherwise, it will useregion-<namespaced-guid-here>based on the settings in the config.