This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Disable storageclient logs when setting admins #1304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ca14b49.
chkeita
changed the title
ranweiler
reviewed
Sep 29, 2021
Co-authored-by: Joe Ranweiler <joe@lemma.co>
chkeita
force-pushed
the
chkeita/bug_fix2
branch
from
64243c8
to
1110cae
Compare
ranweiler
approved these changes
Oct 1, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
When checking the existence of a table. The
storageclientmodule logs an error message and throws an exception.The exception is handled internally bu the message shows up in our deployment logs (see #1297).
This PR disables the logs for that module.