Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

App role assignment not respected when creating a new cli app registration #1308

Merged
merged 4 commits into from
Oct 1, 2021
Merged

App role assignment not respected when creating a new cli app registration #1308

merged 4 commits into from
Oct 1, 2021

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Sep 30, 2021 •
edited

Fix a bug in create_application_registration when assigning the approle, the value was hardcoded to ManagedNode.

Closes #1292

validation:

  • create a new cli registration python registration.py create_cli_registration <instance> <subscription>
  • in azure the azure portal : Azure Active Directory >> Enterprise Application >> <registration_name> > Permissions
    verify that the CliClient is assigned

@chkeita chkeita changed the title [FIX] App role assignment not respected when creating a new cli app r… App role assignment not respected when creating a new cli app registration Sep 30, 2021
ranweiler
ranweiler approved these changes Oct 1, 2021
View reviewed changes
src/deployment/registration.py Show resolved Hide resolved
@chkeita chkeita merged commit 1c497fc into microsoft:main Oct 1, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ranweiler ranweiler ranweiler approved these changes

@stishkin stishkin stishkin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App role assignment not respected when creating a new cli app registration
3 participants
@chkeita @ranweiler @stishkin