Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix client_secret auth behavior #1376

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Oct 20, 2021

Summary of the Pull Request

fix bug during authentication of client secret. The code was ignoring unexpected errors

Validation Steps Performed

see bug #1330
new error message

ERROR:cli:command failed: error: invalid_grant
'AADSTS501051: Application '8b17aa93-15a1-4ce3-8c38-4ac739be3ec6'(chkeitaonefuzz_cli) is not assigned to a role for the application 'api://chkeitaonefuzz.azurewebsites.net'(chkeitaonefuzz).
Trace ID: 86d581ee-49b3-49a7-81f1-998d804c6500
Correlation ID: 23d1db3b-60b4-487a-9597-d4f6ec860475
Timestamp: 2021-10-25 23:21:46Z'

- Stop strying new scopes when encountering an unexpected error
@chkeita chkeita marked this pull request as ready for review October 25, 2021 23:24
@chkeita chkeita requested a review from stishkin October 26, 2021 00:10
@chkeita chkeita merged commit 7c86a3d into microsoft:main Oct 26, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong Error message when connecting to an unauthorized instance when using a client_secret
2 participants