This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Fix error regex when removing invalid application in add_preauthorized_app #1408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stishkin
approved these changes
Oct 28, 2021
ranweiler
reviewed
Oct 28, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This fix an issue when
add_preauthorized_apptries to remove an invalid application id.The regex used did not correctly capture the object_id
To validate:
python .\registration.py create_cli_registration <instance> <subscription>The creation should be successful with at least one warning with the message
Property PreAuthorizedApplication references applications <application id> that cannot be found.