Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fixing VMSS Re-Image 7-Day Timer #1616

Merged

Conversation

nharper285
Copy link
Contributor

@nharper285 nharper285 commented Jan 25, 2022

Summary of the Pull Request

What is this about?
The 7-Day VMSS Re-Image timer currently does not work. It relies upon the node 'TimeStamp' entry which is actually updated every few minutes when new node heartbeats come in. I am creating a new table entry - created_at - to fix this behavior.

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

  • Set timer to 15 min and observe timer reimage
  • Deploy old instance with scaleset (w/o init_at field). Then deploy update over old instance and confirm scaleset updates with new field.

@chkeita
Copy link
Contributor

chkeita commented Jan 26, 2022

@nharper285 can you update the description with your validation steps

src/api-service/__app__/onefuzzlib/workers/nodes.py Outdated Show resolved Hide resolved
src/api-service/__app__/onefuzzlib/workers/nodes.py Outdated Show resolved Hide resolved
src/pytypes/onefuzztypes/models.py Show resolved Hide resolved
src/pytypes/onefuzztypes/models.py Outdated Show resolved Hide resolved
src/api-service/__app__/onefuzzlib/agent_events.py Outdated Show resolved Hide resolved
@nharper285 nharper285 merged commit 6100191 into microsoft:main Jan 27, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Feb 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants