This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 195
Fixing VMSS Re-Image 7-Day Timer #1616
Merged
nharper285
merged 20 commits into
microsoft:main
from
nharper285:user/noharper/timestamp-timer-fix
Jan 27, 2022
Merged
Fixing VMSS Re-Image 7-Day Timer #1616
nharper285
merged 20 commits into
microsoft:main
from
nharper285:user/noharper/timestamp-timer-fix
Jan 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
reviewed
Jan 25, 2022
chkeita
approved these changes
Jan 26, 2022
chkeita
reviewed
Jan 26, 2022
@nharper285 can you update the description with your validation steps |
ranweiler
reviewed
Jan 26, 2022
hayleycall
approved these changes
Jan 26, 2022
ranweiler
reviewed
Jan 26, 2022
bmc-msft
reviewed
Jan 26, 2022
Co-authored-by: Joe Ranweiler <joe@lemma.co>
ghost
locked as resolved and limited conversation to collaborators
Feb 26, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
The 7-Day VMSS Re-Image timer currently does not work. It relies upon the node 'TimeStamp' entry which is actually updated every few minutes when new node heartbeats come in. I am creating a new table entry - created_at - to fix this behavior.
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?