This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Add the setup state to the unavailable list #1731
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
There is a race condition when creating a scale set. The following sequence of events causes an error:
init
orsetup
state.Step 3 will fail because auto scaling does not allow the minimum number of instances in the configuration to be smaller than the number of nodes with scale-in protection.
To fix this race condition, nodes cannot pick up work until auto scaling is configured. Since auto scaling is added while the scale set is still in the 'setup' state, nodes cannot pick up work while the scale set is in 'init' or 'setup'.
PR Checklist
Info on Pull Request
What does this include?
Prevent nodes from picking up work until the scale set is at least 'running'.
Validation Steps Performed
How does someone test & validate?