This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
[C# Port] Adding new Proxy Update Queue Function. #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chkeita
reviewed
Apr 6, 2022
chkeita
reviewed
Apr 7, 2022
chkeita
reviewed
Apr 7, 2022
tevoinea
reviewed
Apr 7, 2022
tevoinea
reviewed
Apr 7, 2022
…m/microsoft/onefuzz into user/noharper/proxy-update-func-2
chkeita
reviewed
Apr 8, 2022
chkeita
reviewed
Apr 8, 2022
chkeita
approved these changes
Apr 8, 2022
chkeita
reviewed
Apr 8, 2022
Co-authored-by: Cheick Keita <chkeita@microsoft.com>
…m/microsoft/onefuzz into user/noharper/proxy-update-func-2
tevoinea
reviewed
Apr 11, 2022
tevoinea
reviewed
Apr 11, 2022
tevoinea
approved these changes
Apr 11, 2022
AdamL-Microsoft
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Adding QueueProxyUpdate. * Setting to serializer. * Updates. * Updating with new ORM model and [model]Operation. * Fixing return type. * Working on changes. * Tested and ready for review. * Formatting. * Removing test code. * Update src/ApiService/Tests/OrmTest.cs Co-authored-by: Cheick Keita <chkeita@microsoft.com> * Fixing tests. * Fixing tests again. * Asserting null in tests. * Adding null param. * Removing whitespace. * syntax error. Co-authored-by: Cheick Keita <chkeita@microsoft.com>
AdamL-Microsoft
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Adding QueueProxyUpdate. * Setting to serializer. * Updates. * Updating with new ORM model and [model]Operation. * Fixing return type. * Working on changes. * Tested and ready for review. * Formatting. * Removing test code. * Update src/ApiService/Tests/OrmTest.cs Co-authored-by: Cheick Keita <chkeita@microsoft.com> * Fixing tests. * Fixing tests again. * Asserting null in tests. * Adding null param. * Removing whitespace. * syntax error. Co-authored-by: Cheick Keita <chkeita@microsoft.com>
AdamL-Microsoft
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Adding QueueProxyUpdate. * Setting to serializer. * Updates. * Updating with new ORM model and [model]Operation. * Fixing return type. * Working on changes. * Tested and ready for review. * Formatting. * Removing test code. * Update src/ApiService/Tests/OrmTest.cs Co-authored-by: Cheick Keita <chkeita@microsoft.com> * Fixing tests. * Fixing tests again. * Asserting null in tests. * Adding null param. * Removing whitespace. * syntax error. Co-authored-by: Cheick Keita <chkeita@microsoft.com>
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Porting QueueProxyUpdate to C# for refactor.
PR Checklist
Info on Pull Request
What does this include?
New:
Changed:
Validation Steps Performed
How does someone test & validate?
I deployed the function locally and connected it to the proxy queue in an active instance. The function properly processed the entries on the queue.