This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Delete nodes when they're done #1763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgreisen
approved these changes
Apr 8, 2022
chkeita
approved these changes
Apr 8, 2022
chkeita
reviewed
Apr 8, 2022
mgreisen
reviewed
Apr 12, 2022
…ea/onefuzz into tevoinea/AgressNodeDelete
AdamL-Microsoft
pushed a commit
that referenced
this pull request
Apr 18, 2022
* Delete nodes when they're done * Missed a file * Load node disposal strategy from env var * Lint * Fix subtle bug * Deleting doesn't work, will 'decomission' nodes once they complete work * Missed a file * Remove logging line
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
In order to maintain a consistent VMSS instance model, we're opting to delete nodes once they complete their work. Newly created nodes will have the latest model which will hopefully fix the issue.
This change opts to delete nodes instead of reimaging them when they are complete.
PR Checklist
Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?