This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

C# Refactor For Webhook Queue #1818

Merged

nharper285 merged 35 commits into microsoft:main from nharper285:user/noharper/refactor-webhook-queue

Apr 26, 2022

Contributor

nharper285 commented Apr 20, 2022

Summary of the Pull Request

What is this about?

PR Checklist

Applies to work item: #xxx
CLA signed. If not, go over here and sign the CLI.
Tests added/passed
Requires documentation to be updated
I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

How does someone test & validate?

nharper285 and others added 2 commits

April 20, 2022 10:24


          Working on Webhook Queue Changes.


          Merge branch 'main' into user/noharper/refactor-webhook-queue

0f3aced

stishkin reviewed

View reviewed changes

src/ApiService/ApiService/QueueWebhooks.cs Outdated Show resolved Hide resolved

stishkin reviewed

View reviewed changes

src/ApiService/ApiService/QueueWebhooks.cs Outdated Show resolved Hide resolved

nharper285 marked this pull request as draft

April 20, 2022 17:28

stishkin reviewed

View reviewed changes

src/ApiService/ApiService/onefuzzlib/WebhookOperations.cs Outdated Show resolved Hide resolved

nharper285 and others added 3 commits

April 21, 2022 09:43


          Initial Push w/ Webhook Work.

0a4d45e


          Merge branch 'main' into user/noharper/refactor-webhook-queue

e1316e0


          Initial Push. Working on Testing.

9710dae

nharper285 marked this pull request as ready for review

April 22, 2022 00:18


          Merge branch 'main' into user/noharper/refactor-webhook-queue

044044f

chkeita reviewed

View reviewed changes

src/ApiService/ApiService/onefuzzlib/Creds.cs Outdated Show resolved Hide resolved

Member

tevoinea commented Apr 22, 2022

There's an empty file src/ApiService/ApiService/OneFuzzTypes/Primitives.cs

nharper285 and others added 7 commits

April 22, 2022 08:56


          Merge branch 'main' into user/noharper/refactor-webhook-queue

139005b


          Moving InstanceId

2c389ce


          Removing primitives.

73b34a7


          Formatting.

eadd820


          Fixing formatting?

ce083d6


          Moving GetInstanceId to containers.

16b16df


          Moving comments for formatting.

2c10381

tevoinea reviewed

View reviewed changes

src/ApiService/ApiService/onefuzzlib/WebhookMessageLogOperations.cs Outdated Show resolved Hide resolved

nharper285 added 4 commits

April 22, 2022 10:13


          Removing unused dependency.

e96c884


          Comments.

453e945


          Add WebhookEventGrid test.

31b4a57


          Fixing how tests work.

19f9a3d

tevoinea approved these changes

View reviewed changes

Member

tevoinea left a comment

2 small things to check but nothing blocking!

src/ApiService/ApiService/onefuzzlib/WebhookOperations.cs Outdated Show resolved Hide resolved

src/ApiService/ApiService/onefuzzlib/WebhookOperations.cs Show resolved Hide resolved

nharper285 and others added 4 commits

April 25, 2022 11:21


          Merge branch 'main' into user/noharper/refactor-webhook-queue

67c5155


          Working to resolve conflicts.

6fd0a58


          Resolving conflicts.

11ded44


          Merge branch 'main' into user/noharper/refactor-webhook-queue

3cb42b5

nharper285 and others added 11 commits

April 25, 2022 15:34


          Fixing chagnes.

3348ff8


          Merge branch 'main' into user/noharper/refactor-webhook-queue

528c15f


          Tested code.

f8d8caa


          Merge branch 'main' into user/noharper/refactor-webhook-queue

099c77d


          Formatting.

ddb3373


          Merge branch 'user/noharper/refactor-webhook-queue' of https://github…

….com/nharper285/onefuzz into user/noharper/refactor-webhook-queue


          MoreFormatting.

c79c59d


          More formatting.

79b05d6


          Fixing syntax.

78da0dd


          Fixing syntax.

1cc3d8a


          Removing test and webhookmessagelogoperation class.

72a39c3

stishkin approved these changes

View reviewed changes

chkeita approved these changes

View reviewed changes

nharper285 and others added 3 commits

April 26, 2022 11:54


          Using config.

ad9e588


          Merge branch 'main' into user/noharper/refactor-webhook-queue

021778c


          Fixing ProxyOperations.

be3bb3c

nharper285 merged commit 0b1c7ae into microsoft:main

ghost locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.