Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Use sas for agent log download #1920

Merged
merged 1 commit into from
May 10, 2022
Merged

Conversation

tevoinea
Copy link
Member

Summary of the Pull Request

What is this about?
This allows the client to use a SAS URL generated by the service as the authentication mechanism to download a container from a storage account.

It follows this pattern: https://docs.microsoft.com/en-us/azure/storage/common/storage-sas-overview#when-to-use-a-shared-access-signature

PR Checklist

  • Applies to work item: #xxx
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

  1. Download containers via SAS URL
  2. Some small dev container quality of life improvements

Validation Steps Performed

How does someone test & validate?

  1. Run onefuzz debug logs get --job_id {job_id}
  2. Check the files were still downloaded

@tevoinea tevoinea merged commit 779a67e into main May 10, 2022
@tevoinea tevoinea deleted the tevoinea/UseSasToDownloadAgentLogs branch May 16, 2022 10:39
@ghost ghost locked as resolved and limited conversation to collaborators Jun 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants