This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Only save the job once when creating it #2289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chkeita
commented
Aug 23, 2022
•
chkeita
commented
- logging a warning in C# instead of an exception just like the original code
- Fix the logic of creation of jobs. Only save once to avoid the job being picked up by the scheduler before it is ready
- check-pr passed
mgreisen
approved these changes
Aug 23, 2022
chkeita
force-pushed
the
rewrite/timer_task
branch
from
04881ed
to
8815df4
Compare
chkeita
changed the title
Porges
approved these changes
Aug 24, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.