This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Disable PoolName validation #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stishkin
approved these changes
Sep 28, 2022
mgreisen
approved these changes
Sep 28, 2022
Codecov Report
@@ Coverage Diff @@
## main #2459 +/- ##
=======================================
Coverage 31.02% 31.02%
=======================================
Files 253 253
Lines 29023 29023
=======================================
Hits 9003 9003
Misses 20020 20020 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Porges
force-pushed
the
disable-poolname-validation-2
branch
from
a16eae2
to
6bf39bc
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to want some restrictions on pool names in future, but for now we are disabling validation to prevent breaking any existing users with non-conforming pool names.