Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

setting nodes for shutdown in scaleset shutdown #252

Merged
merged 3 commits into from
Nov 3, 2020

Conversation

anshuman-goel
Copy link
Contributor

@anshuman-goel anshuman-goel commented Nov 2, 2020

Summary of the Pull Request

I have observed that shutting down scaleset doesn't actually removes node. using similar strategy as in pools for it.

PR Checklist

  • Applies to work item: Manage Scalesets within pool #124
  • CLA signed. If not, go over here and sign the CLI.
  • Tests added/passed
  • Requires documentation to be updated
  • I've discussed this with core contributors already. If not checked, I'm ready to accept this work might be rejected in favor of a different grand plan. Issue number where discussion took place: #xxx

Info on Pull Request

What does this include?

Validation Steps Performed

manually

@bmc-msft
Copy link
Contributor

bmc-msft commented Nov 3, 2020

I understand the issue you're trying to address but I think aligning Scaleset.shutdown and Pool.shutdown is probably in order rather than this PR.

I'll work on that tomorrow.

@bmc-msft
Copy link
Contributor

bmc-msft commented Nov 3, 2020

In the short term, going forward with this PR. We can address cleaning up pool/scaleset/node shutdown cleanup in a later effort.

@bmc-msft
Copy link
Contributor

bmc-msft commented Nov 3, 2020

Performing integration tests

@bmc-msft bmc-msft merged commit 4ef489b into microsoft:main Nov 3, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants