Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

pass the machine_identity from the agent to the task #2662

Merged
merged 12 commits into from Dec 1, 2022

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Nov 30, 2022

The default value of the MachineIdentity was being passed to the task instead of the actual machine identity. This would cause all agent to have the id 00000000-0000-0000-0000-000000000000

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2022

Codecov Report

Merging #2662 (f2703f1) into main (38dfa66) will decrease coverage by 4.43%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2662      +/-   ##
==========================================
- Coverage   29.31%   24.88%   -4.44%     
==========================================
  Files         289      121     -168     
  Lines       35693    12512   -23181     
==========================================
- Hits        10463     3113    -7350     
+ Misses      25230     9399   -15831     
Impacted Files Coverage Δ
src/agent/onefuzz-agent/src/debug.rs
src/agent/onefuzz-agent/src/main.rs
src/agent/onefuzz-agent/src/worker.rs
src/agent/onefuzz-task/src/local/common.rs
src/agent/onefuzz-task/src/local/coverage.rs
...c/agent/onefuzz-task/src/local/generic_analysis.rs
...ent/onefuzz-task/src/local/generic_crash_report.rs
.../agent/onefuzz-task/src/local/generic_generator.rs
src/agent/onefuzz-task/src/local/libfuzzer.rs
...t/onefuzz-task/src/local/libfuzzer_crash_report.rs
... and 158 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chkeita chkeita marked this pull request as ready for review November 30, 2022 23:07
@chkeita chkeita enabled auto-merge (squash) December 1, 2022 23:02
@chkeita chkeita merged commit 62647e0 into microsoft:main Dec 1, 2022
@nharper285 nharper285 mentioned this pull request Dec 2, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants