This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Sematically validate notification configs #2850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inea/SematicallyValidateNotificationConfigs
chkeita
reviewed
Feb 16, 2023
chkeita
approved these changes
Feb 16, 2023
Co-authored-by: Cheick Keita <kcheick@gmail.com>
chkeita
added a commit
to chkeita/onefuzz
that referenced
this pull request
Feb 16, 2023
* Add new command * Update remaining jinja templates and references to use scriban * Add ado template validation * Validate ado and github templates * Remove unnecessary function * Update src/ApiService/ApiService/OneFuzzTypes/Model.cs Co-authored-by: Cheick Keita <kcheick@gmail.com> --------- Co-authored-by: Cheick Keita <kcheick@gmail.com>
chkeita
added a commit
that referenced
this pull request
Feb 23, 2023
* adding extra container to tasks * setup expand * build fix * generate docs * build fix * build fix * build fix * format * format * build fix * fix extra container references * format * Update "Needs Triage" label to the one we use. (#2845) * Report extension errors (#2846) Old failure message: ``` failed to launch extension ``` New failure message: ``` failed to launch extension(s): Errors for extension 'CustomScriptExtension': :Error: ProvisioningState/failed/3 (Provisioning failed) - Failed to download all specified files. Exiting. Error Message: The remote server returned an error: (400) Bad Request. ``` * Sematically validate notification configs (#2850) * Add new command * Update remaining jinja templates and references to use scriban * Add ado template validation * Validate ado and github templates * Remove unnecessary function * Update src/ApiService/ApiService/OneFuzzTypes/Model.cs Co-authored-by: Cheick Keita <kcheick@gmail.com> --------- Co-authored-by: Cheick Keita <kcheick@gmail.com> * adding extra container to integration tests * adding doc * update tests * format * build and clippy fix * Update src/agent/onefuzz-task/src/tasks/report/generic.rs Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com> --------- Co-authored-by: Marc Greisen <mgreisen@microsoft.com> Co-authored-by: George Pollard <gpollard@microsoft.com> Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>
Merged
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
What is this about?
Closes #994
Checks notification config for valid properties
Info on Pull Request
What does this include?
EnableValidateNotificationConfigSemanticsthat is defaulted toonat deploy timeAdo.csandGithubIssues.csValidation Steps Performed
How does someone test & validate?
ERROR:cli:command failed: request did not succeed (400: INVALID_CONFIGURATION): Failed to connect to https://dev.azure.com/fuzzfest using the provided tokenunique_fields-> CLI returns:ERROR:cli:command failed: request did not succeed (400: INVALID_CONFIGURATION): The following unique fields are not valid fields for this project: system.title123412341234 You can find the valid fields for your project by following these steps: https://learn.microsoft.com/en-us/azure/devops/boards/work-items/work-item-fields?view=azure-devops#review-fieldsERROR:cli:command failed: request did not succeed (400: INVALID_CONFIGURATION): Failed to login to github.com with user tevoinea and the provided Personal Access TokenERROR:cli:command failed: request did not succeed (400: INVALID_CONFIGURATION): Failed to access repository: tevoinea/udp-parserwqeqweqwe