This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
update the ado logic to consume the list of existing items once #3014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov Report
@@ Coverage Diff @@
## main #3014 +/- ##
==========================================
+ Coverage 29.42% 30.03% +0.61%
==========================================
Files 305 275 -30
Lines 36550 30963 -5587
==========================================
- Hits 10755 9301 -1454
+ Misses 25795 21662 -4133
... and 53 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
tevoinea
reviewed
Apr 12, 2023
tevoinea
approved these changes
Apr 12, 2023
Co-authored-by: Teo Voinea <58236992+tevoinea@users.noreply.github.com>
tevoinea
reviewed
Apr 18, 2023
src/ApiService/ApiService/onefuzzlib/notifications/GithubIssues.cs
Outdated
Show resolved
Hide resolved
tevoinea
approved these changes
Apr 18, 2023
Porges
approved these changes
Apr 19, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This change updates the logic of how we consume the list of matching work items from the server.
We used to load all work items in memory before processing them. This could potentially create memory pressure if a lot of items matched. We now consume them in batches.
A new endpoint
/api/notification/teststo simplify the testing of notification has been added.it can be access via the command
onefuzz debug notification test_template <task_id> <notification_config>closes #3038