Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Store authentication info in keyvault #3127

Merged
merged 26 commits into from
Jun 6, 2023
Merged

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented May 23, 2023

Summary of the Pull Request

Convert the Authentication fields to ISecret

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2023

Codecov Report

Merging #3127 (fcddb73) into main (9aa2519) will decrease coverage by 1.64%.
The diff coverage is 45.76%.

@@            Coverage Diff             @@
##             main    #3127      +/-   ##
==========================================
- Coverage   31.60%   29.97%   -1.64%     
==========================================
  Files         308      327      +19     
  Lines       36568    38816    +2248     
==========================================
+ Hits        11559    11634      +75     
- Misses      25009    27182    +2173     
Impacted Files Coverage Δ
src/ApiService/ApiService/Functions/Tasks.cs 22.04% <0.00%> (-0.18%) ⬇️
src/ApiService/ApiService/TestHooks/TestHooks.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Extension.cs 0.00% <0.00%> (ø)
...piService/ApiService/onefuzzlib/ProxyOperations.cs 0.00% <0.00%> (ø)
...ervice/ApiService/onefuzzlib/ScalesetOperations.cs 4.74% <0.00%> (-0.04%) ⬇️
...c/ApiService/ApiService/onefuzzlib/VmOperations.cs 0.00% <0.00%> (ø)
...Service/ApiService/onefuzzlib/notifications/Ado.cs 0.00% <0.00%> (ø)
...piService/onefuzzlib/notifications/GithubIssues.cs 0.00% <0.00%> (ø)
...rvice/ApiService/onefuzzlib/notifications/Teams.cs 0.00% <0.00%> (ø)
src/ApiService/Tests/OrmModelsTest.cs 0.00% <0.00%> (ø)
... and 12 more

... and 16 files with indirect coverage changes

@chkeita chkeita requested review from Porges and tevoinea June 6, 2023 01:17
@chkeita chkeita marked this pull request as ready for review June 6, 2023 01:17
@chkeita
Copy link
Contributor Author

chkeita commented Jun 6, 2023

Check-pr passed

Copy link
Member

@tevoinea tevoinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-blocking comments

@chkeita chkeita merged commit b44cff5 into microsoft:main Jun 6, 2023
24 checks passed
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants