This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Don’t validate error codes on client side #3131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3131 +/- ##
==========================================
+ Coverage 29.43% 30.12% +0.68%
==========================================
Files 302 128 -174
Lines 35181 14002 -21179
==========================================
- Hits 10357 4218 -6139
+ Misses 24824 9784 -15040
|
|
Passed check-pr. |
tevoinea
approved these changes
May 25, 2023
chkeita
approved these changes
May 30, 2023
AdamL-Microsoft
added a commit
that referenced
this pull request
Jun 5, 2023
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop
pydanticfrom validating error codes returned from the service. This prevents the problem in #3129 from happening.Include the error code name in the JSON returned from the service.