Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Include a reason when a task has never started #3148

Merged
merged 5 commits into from Jun 5, 2023

Conversation

chkeita
Copy link
Contributor

@chkeita chkeita commented Jun 1, 2023

Summary of the Pull Request

  • Added a reason field to MarkStopping
  • Added a new ErrorCode TASK_CANCELLED to differentiate cancellation from failure.
  • If a task is cancelled all dependent task are cancelled

closes #3147

@chkeita chkeita changed the title Include a reason to mark a task as failed Include a reason when a task has never started Jun 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jun 2, 2023

Codecov Report

Merging #3148 (0960f40) into main (5d8f245) will increase coverage by 0.00%.
The diff coverage is 63.63%.

@@           Coverage Diff           @@
##             main    #3148   +/-   ##
=======================================
  Coverage   31.59%   31.59%           
=======================================
  Files         308      308           
  Lines       36563    36564    +1     
=======================================
+ Hits        11552    11553    +1     
  Misses      25011    25011           
Impacted Files Coverage Δ
src/ApiService/ApiService/Functions/Tasks.cs 22.22% <0.00%> (ø)
src/ApiService/ApiService/Functions/TimerTasks.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/OneFuzzTypes/Enums.cs 32.39% <ø> (ø)
.../ApiService/ApiService/onefuzzlib/JobOperations.cs 10.34% <0.00%> (ø)
...ApiService/ApiService/onefuzzlib/TaskOperations.cs 31.09% <85.71%> (+0.29%) ⬆️
src/ApiService/ApiService/Functions/AgentEvents.cs 55.60% <100.00%> (ø)

@chkeita chkeita merged commit bada352 into microsoft:main Jun 5, 2023
24 checks passed
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more context the task failure error when the task is never started.
3 participants