Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Add cache for coverage locations and debuginfo #3218

Merged
merged 7 commits into from Jun 23, 2023

Conversation

ranweiler
Copy link
Member

@ranweiler ranweiler commented Jun 22, 2023

Closes #3216.

This PR does not implement caching or analysis reuse in the OneFuzz coverage task, but is a preqreq for doing so.

@ranweiler
Copy link
Member Author

Manually tested using the updated record example to ensure the cache is being hit when testing multiple inputs against the same target using the -d option.

@codecov-commenter
Copy link

codecov-commenter commented Jun 22, 2023

Codecov Report

Merging #3218 (ecf0c9f) into main (e603fa9) will increase coverage by 0.05%.
The diff coverage is 60.00%.

@@            Coverage Diff             @@
##             main    #3218      +/-   ##
==========================================
+ Coverage   29.49%   29.54%   +0.05%     
==========================================
  Files         332      332              
  Lines       39106    39195      +89     
==========================================
+ Hits        11535    11582      +47     
- Misses      27571    27613      +42     
Impacted Files Coverage Δ
src/agent/coverage/src/record.rs 75.45% <50.00%> (-2.44%) ⬇️
src/agent/coverage/src/binary.rs 54.59% <55.12%> (-15.70%) ⬇️
src/agent/coverage/src/record/windows.rs 25.26% <85.71%> (+2.06%) ⬆️
src/agent/coverage/src/record/linux.rs 65.21% <100.00%> (+2.71%) ⬆️

... and 3 files with indirect coverage changes

@ranweiler
Copy link
Member Author

Integration tests passed, manually inspected coverage output files.

@tevoinea tevoinea merged commit a941020 into microsoft:main Jun 23, 2023
24 checks passed
@ranweiler ranweiler deleted the debuginfo-cache branch June 23, 2023 16:03
AdamL-Microsoft added a commit that referenced this pull request Jun 23, 2023
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable caching debuginfo analysis
3 participants