Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Fix timestamp #3237

Merged
merged 9 commits into from Jul 3, 2023
Merged

Fix timestamp #3237

merged 9 commits into from Jul 3, 2023

Conversation

Porges
Copy link
Member

@Porges Porges commented Jun 27, 2023

Closes #3171.

TimeStamp should be cased Timestamp to match the Python API.

Timestamp was also missing and/or wrong from several of the new response types.

@Porges Porges marked this pull request as ready for review June 28, 2023 23:57
@codecov-commenter
Copy link

codecov-commenter commented Jun 29, 2023

Codecov Report

Merging #3237 (53498ab) into main (c61aa0a) will increase coverage by 0.30%.
The diff coverage is 40.00%.

@@            Coverage Diff             @@
##             main    #3237      +/-   ##
==========================================
+ Coverage   29.65%   29.95%   +0.30%     
==========================================
  Files         332      301      -31     
  Lines       39290    33662    -5628     
==========================================
- Hits        11651    10084    -1567     
+ Misses      27639    23578    -4061     
Impacted Files Coverage Δ
src/ApiService/ApiService/Functions/Tasks.cs 19.67% <0.00%> (-0.17%) ⬇️
...piService/ApiService/onefuzzlib/ProxyOperations.cs 0.00% <0.00%> (ø)
src/ApiService/ApiService/onefuzzlib/Scheduler.cs 14.51% <0.00%> (ø)
...rvice/ApiService/onefuzzlib/TaskEventOperations.cs 7.14% <0.00%> (ø)
src/ApiService/Tests/OrmTest.cs 3.88% <0.00%> (ø)
...rc/ApiService/ApiService/OneFuzzTypes/Responses.cs 77.31% <62.50%> (-0.46%) ⬇️
...rvice/ApiService/onefuzzlib/orm/EntityConverter.cs 90.59% <100.00%> (ø)

... and 54 files with indirect coverage changes

@Porges Porges enabled auto-merge (squash) July 3, 2023 20:58
@Porges Porges merged commit b5c7a0c into main Jul 3, 2023
24 checks passed
@AdamL-Microsoft AdamL-Microsoft mentioned this pull request Jul 13, 2023
@Porges Porges deleted the timestamp-fix branch July 13, 2023 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OneFuzz API always returns None for timestamp on jobs using the python SDK
3 participants