This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3386 +/- ##
==========================================
- Coverage 34.46% 34.42% -0.05%
==========================================
Files 299 299
Lines 36201 36245 +44
==========================================
Hits 12478 12478
- Misses 23723 23767 +44
|
kananb
force-pushed
the
kanan/semantic-validation
branch
3 times, most recently
from
August 21, 2023 23:50
78dfed1
to
3db9024
Compare
tevoinea
reviewed
Aug 23, 2023
tevoinea
reviewed
Aug 23, 2023
tevoinea
reviewed
Aug 23, 2023
tevoinea
reviewed
Aug 23, 2023
tevoinea
reviewed
Aug 23, 2023
tevoinea
reviewed
Aug 23, 2023
tevoinea
reviewed
Aug 23, 2023
kananb
force-pushed
the
kanan/semantic-validation
branch
from
August 25, 2023 22:19
c9082cb
to
229f88f
Compare
tevoinea
reviewed
Aug 28, 2023
tevoinea
reviewed
Aug 28, 2023
tevoinea
reviewed
Aug 28, 2023
tevoinea
approved these changes
Aug 28, 2023
This reverts commit ad96169.
kananb
force-pushed
the
kanan/semantic-validation
branch
from
August 28, 2023 21:59
2bd5a18
to
aaf2054
Compare
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Adds validation for Iteration/AreaPath when a job is submitted with a notification config and for
onefuzz debug notification test_template
.PR Checklist
config.json
Schema Semantics #2985,debug notification test_template
returns "success" when AreaPath is invalid #3220Info on Pull Request
What does this include?
Validation Steps Performed
How does someone test & validate?