Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Multi-tenant authentication support in CLI #346

Merged
22 commits merged into from
Jan 6, 2021
Merged

Conversation

andrew-slutsky
Copy link
Contributor

Summary of the Pull Request

These are purposed changes to resolve ticket #344

I have tested these changes and it does not effect or break the current functionality.

I don't necessarily expect this PR to be merged without some tweaks. I'll coordinate over the next week or so to get it right.

One coding issue I would like to discuss/highlight is the assumption (in code) that if "--tenant_domain" is used then the 'common' authority is also used. I am open to suggestions.

PR Checklist

Info on Pull Request

Minor changes to the config file and the login process.

Validation Steps Performed

Tested these changes with a multi-tenant enabled endpoint and a single-tenant endpoint.

src/cli/onefuzz/backend.py Outdated Show resolved Hide resolved
@bmc-msft bmc-msft added this to In progress in Public Roadmap Nov 30, 2020
src/cli/onefuzz/backend.py Outdated Show resolved Hide resolved
Copy link
Contributor Author

@andrew-slutsky andrew-slutsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@bmc-msft
Copy link
Contributor

@anslutsk , there is an issue with Unicode. I made andrew-slutsky#2 to address this issue. If you merge that PR into your fork, this PR should be good to go.

@bmc-msft bmc-msft linked an issue Dec 16, 2020 that may be closed by this pull request
@bmc-msft bmc-msft changed the title #344: Multi-tenant authentication support in CLI Multi-tenant authentication support in CLI Jan 5, 2021
@bmc-msft bmc-msft self-requested a review January 6, 2021 12:34
@ghost
Copy link

ghost commented Jan 6, 2021

Hello @bmc-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 883f38c into microsoft:main Jan 6, 2021
Public Roadmap automation moved this from In progress to Done Jan 6, 2021
@bmc-msft bmc-msft moved this from Done to Recently Released in Public Roadmap Jan 11, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Apr 17, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Public Roadmap
  
Recently Released
Development

Successfully merging this pull request may close these issues.

Multi-tenant authentication support in CLI
3 participants