This repository has been archived by the owner on Nov 1, 2023. It is now read-only.
prevent object id collision in hide_secrets #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this fixes an issue related to object id reuse that can occur making the object identification cache fail. Instead, this simplifies the hide_secrets to always recurse and use setattr to always set the value based on the recursion. Note, the object id reuse issue was seen in the `events.filter_event_recurse` development and this was the fix for the id reuse there. Python documentation states: id(object): Return the “identity” of an object. This is an integer (or long integer) which is guaranteed to be unique and constant for this object during its lifetime. Two objects with non-overlapping lifetimes may have the same id() value.
|
@ranweiler this should fix the build issues you're seeing. |
ranweiler
approved these changes
May 27, 2021
| hider: Callable[["SecretData"], None], | ||
| visited: Set[int] = set(), | ||
| ) -> None: | ||
| if id(model) in visited: |
There was a problem hiding this comment.
So this is where the action is. Great catch!
chkeita
approved these changes
May 27, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue related to object id reuse that can occur making the object identification cache fail. Instead, this simplifies
hide_secretsto always recurse and usesetattrto always set the value based on the recursion.Note, the object id reuse issue was seen in the
events.filter_event_recursedevelopment and this was the fix for the id reuse there.Python documentation states: