Fix the build breaks the release pipeline and some C++ warnings #372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanshaw24
reviewed
Feb 28, 2023
| #include "ustring.h" | ||
|
|
||
| #include <regex> | ||
| #include <list> |
There was a problem hiding this comment.
Perfect - was going to say this is what caused the ci failures in the previous run, should be fine now.
sayanshaw24
previously approved these changes
Feb 28, 2023
wenbingl
added a commit
that referenced
this pull request
Mar 1, 2023
* fix the break in release pipeline * code cleanup and the warnings fixing. * Update ci.yml for Azure Pipelines * Update ci.yml for Azure Pipelines * fix linux build * one more fixing * again? * fixing for macOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.