Refactor the header file directory and integrate the eager tensor implementation #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wenbingl
commented
Apr 10, 2024
•
wenbingl
commented
- rename includes folder to include (w/o s)
- move all custom-op related header file a sub-folder
- integrate Cheng's POC of eager mode.
- Add the Tokenizer header files to validate the refactored folder structure, implementation will be merged by another PR.
- Add a stub unit test for tokenizer api, the implementation will be merged later
wenbingl
changed the title
souptc
previously approved these changes
Apr 16, 2024
| } | ||
|
|
||
| #define PARSE_INPUT(data_type, onnx_type) \ | ||
| PARSE_INPUT_BASE(const Custom::Tensor<data_type>*, onnx_type) \ |
There was a problem hiding this comment.
we can use the same tricks like tensor_tuple.inc to make this part more debuggable.
souptc
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.