Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom ops ReplaceZero #739

Merged
merged 8 commits into from
Jun 18, 2024
Merged

Add custom ops ReplaceZero #739

merged 8 commits into from
Jun 18, 2024

Conversation

xadupre
Copy link
Member

@xadupre xadupre commented Jun 6, 2024

No description provided.

@xadupre xadupre marked this pull request as ready for review June 7, 2024 07:30
@xadupre xadupre requested a review from a team as a code owner June 7, 2024 07:30
Copy link
Contributor

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider

  1. format the code
  2. add a few more details. (1) how to run this test, (2) kernel selection mechanism to explain why you define two kernels for fp16 and fp32.
  3. avoid abbreviations as function name.

@wschin
Copy link
Contributor

wschin commented Jun 10, 2024

Please ping me when you want me to review again. Thanks.

@xadupre
Copy link
Member Author

xadupre commented Jun 12, 2024

I chose cvt for convert, I thought it was a common abbrevation. I replaced by cast. For float32, float16, we can extend to bfloat16 if needed. I chose not to reduce compilation time but we definitly can add it. What do you mean by how to run the unit tests? There is one file associated to all the kernel implemented in that folder: test/cuda/test_cudaops.py. I just extended it with one of two models per kernel.

Copy link
Contributor

@wschin wschin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@xadupre xadupre merged commit bef5f07 into microsoft:main Jun 18, 2024
45 checks passed
@xadupre xadupre self-assigned this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants