Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommendation to improve MNIST example #2157

Closed
xxtsxxts opened this issue Oct 17, 2019 · 4 comments
Closed

Recommendation to improve MNIST example #2157

xxtsxxts opened this issue Oct 17, 2019 · 4 comments
Assignees
Labels
documentation improvements or additions to documentation; typically submitted using template stale issues that have not been addressed in a while; categorized by a bot

Comments

@xxtsxxts
Copy link

Hey,
I'm a new user to ONNXRuntime, I got some suggestion to improve MNIST sample.
1.Add Python as a prerequisite for building OnnxRuntime at https://github.com/microsoft/onnxruntime/tree/master/samples/c_cxx
2.fix bug
Please add "const OrtApi* Ort::g_api = OrtGetApiBase()->GetApi(ORT_API_VERSION);" to MNIST.cpp
https://github.com/microsoft/onnxruntime/blob/master/samples/c_cxx/MNIST/MNIST.cpp
3.Please add step "Explictly copy model.onnx into the MNIST folder to run MNIST.exe" into readme file
https://github.com/microsoft/onnxruntime/tree/master/samples/c_cxx

Thanks.

@snnn snnn added the documentation improvements or additions to documentation; typically submitted using template label Oct 17, 2019
@snnn
Copy link
Member

snnn commented Oct 22, 2019

The second will not be needed, when ONNX Runtime 1.0 is released.

@stale
Copy link

stale bot commented Jul 18, 2020

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the wontfix label Jul 18, 2020
@snnn snnn mentioned this issue Jul 20, 2020
@snnn snnn removed the wontfix label Jul 20, 2020
@stale
Copy link

stale bot commented Sep 20, 2020

This issue has been automatically marked as stale due to inactivity and will be closed in 7 days if no further activity occurs. If further support is needed, please provide an update and/or more details.

@stale stale bot added the stale issues that have not been addressed in a while; categorized by a bot label Sep 20, 2020
@stale
Copy link

stale bot commented Oct 4, 2020

This issue has been automatically closed due to inactivity. Please reactivate if further support is needed.

@stale stale bot closed this as completed Oct 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation improvements or additions to documentation; typically submitted using template stale issues that have not been addressed in a while; categorized by a bot
Projects
None yet
Development

No branches or pull requests

2 participants